From 6f9776dff2b27d4b5378cfb0c79fee872b4b0c28 Mon Sep 17 00:00:00 2001 From: Vishesh 'ironeagle' Bangotra Date: Tue, 20 Jan 2026 23:42:48 +0530 Subject: [PATCH] broken griffe_loader.py if we want to skip import errors. wip flag for the same --- docforge/loader/griffe_loader.py | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/docforge/loader/griffe_loader.py b/docforge/loader/griffe_loader.py index 4274e36..8847367 100644 --- a/docforge/loader/griffe_loader.py +++ b/docforge/loader/griffe_loader.py @@ -73,21 +73,14 @@ class GriffeLoader: project = Project(name=project_name) for module_path in module_paths: - try: - module = self.load_module(module_path) - project.add_module(module) - except Exception as e: - logger.error("Failed to load module %s: %s", module_path, e) - continue + module = self.load_module(module_path) + project.add_module(module) return project def load_module(self, path: str) -> Module: - try: - self._loader.load(path) - griffe_module = self._loader.modules_collection[path] - except Exception as e: - raise ImportError(f"Failed to load module '{path}': {e}") from e + self._loader.load(path) + griffe_module = self._loader.modules_collection[path] return self._convert_module(griffe_module) @@ -104,10 +97,8 @@ class GriffeLoader: for name, member in obj.members.items(): if name.startswith("_"): continue - try: - module.add_object(self._convert_object(member)) - except Exception as e: - logger.warning("Skipping member %s: %s", name, e) + + module.add_object(self._convert_object(member)) return module @@ -123,14 +114,13 @@ class GriffeLoader: docstring=self._safe_docstring(obj), ) - if hasattr(obj, "members"): + try: for name, member in obj.members.items(): if name.startswith("_"): continue - try: - doc_obj.add_member(self._convert_object(member)) - except Exception: - continue + doc_obj.add_member(self._convert_object(member)) + except AliasResolutionError: + pass return doc_obj