fixes for FilterBar.tsx ONLY

This commit is contained in:
2026-06-07 15:35:13 +05:30
parent 4a8ed46c70
commit 4f043f05ab
5 changed files with 50 additions and 62 deletions

View File

@@ -11,7 +11,7 @@ import {
import DoneIcon from "@mui/icons-material/Done"; import DoneIcon from "@mui/icons-material/Done";
import FilterListIcon from "@mui/icons-material/FilterList"; import FilterListIcon from "@mui/icons-material/FilterList";
import { ResourceField, ResourceMode } from "../types/config"; import { ResourceField, ResourceMode } from "../types/config";
import { FilterBarComponents } from "../types/overrides"; import { FilterBarComponents, FieldComponents } from "../types/overrides";
import { getFieldOptions, resolveTemplate } from "../utils/options"; import { getFieldOptions, resolveTemplate } from "../utils/options";
export function FilterAutocomplete({ export function FilterAutocomplete({
@@ -158,6 +158,7 @@ function renderFilterInput(
value: any, value: any,
onChange: (key: string, val: any) => void, onChange: (key: string, val: any) => void,
components?: FilterBarComponents, components?: FilterBarComponents,
fieldComponents?: FieldComponents,
) { ) {
const CustomInput = components?.filterInputs?.[fieldName]; const CustomInput = components?.filterInputs?.[fieldName];
if (CustomInput) { if (CustomInput) {
@@ -167,6 +168,16 @@ function renderFilterInput(
const filterType = field.filterType; const filterType = field.filterType;
if (filterType === "number-range") { if (filterType === "number-range") {
const NumberComponent = fieldComponents?.number;
if (NumberComponent) {
const rangeVal = (value as { min?: string; max?: string }) || {};
return (
<Box sx={{ display: "flex", gap: 1 }}>
<NumberComponent name={`${fieldName}_min`} field={field} value={rangeVal.min ?? ""} onChange={(val: any) => onChange("min", val === "" ? undefined : val)} />
<NumberComponent name={`${fieldName}_max`} field={field} value={rangeVal.max ?? ""} onChange={(val: any) => onChange("max", val === "" ? undefined : val)} />
</Box>
);
}
const rangeVal = (value as { min?: string; max?: string }) || {}; const rangeVal = (value as { min?: string; max?: string }) || {};
return ( return (
<Box sx={{ display: "flex", gap: 1 }}> <Box sx={{ display: "flex", gap: 1 }}>
@@ -179,17 +190,35 @@ function renderFilterInput(
} }
if (filterType === "date-range") { if (filterType === "date-range") {
const DateComponent = fieldComponents?.date;
if (DateComponent) {
const rangeVal = (value as { start?: string; end?: string }) || {};
const dateField = { ...field, type: 'date' as const };
return (
<Box sx={{ display: "flex", gap: 1 }}>
<DateComponent name={`${fieldName}_start`} field={dateField} value={rangeVal.start ?? ""} onChange={(val: string) => onChange("start", val || undefined)} />
<DateComponent name={`${fieldName}_end`} field={dateField} value={rangeVal.end ?? ""} onChange={(val: string) => onChange("end", val || undefined)} />
</Box>
);
}
const rangeVal = (value as { start?: string; end?: string }) || {}; const rangeVal = (value as { start?: string; end?: string }) || {};
return ( return (
<Box sx={{ display: "flex", gap: 1 }}> <Box sx={{ display: "flex", gap: 1 }}>
<TextField type="datetime-local" placeholder="From" size="small" value={rangeVal.start ?? ""} <TextField type="date" placeholder="From" size="small" value={rangeVal.start ?? ""}
onChange={(e) => onChange("start", e.target.value || undefined)} InputLabelProps={{ shrink: true }} sx={{ width: 170 }} /> onChange={(e) => onChange("start", e.target.value || undefined)} InputLabelProps={{ shrink: true }} sx={{ width: 170 }} />
<TextField type="datetime-local" placeholder="To" size="small" value={rangeVal.end ?? ""} <TextField type="date" placeholder="To" size="small" value={rangeVal.end ?? ""}
onChange={(e) => onChange("end", e.target.value || undefined)} InputLabelProps={{ shrink: true }} sx={{ width: 170 }} /> onChange={(e) => onChange("end", e.target.value || undefined)} InputLabelProps={{ shrink: true }} sx={{ width: 170 }} />
</Box> </Box>
); );
} }
const FormFieldComponent = fieldComponents?.FormField;
if (FormFieldComponent) {
return (
<FormFieldComponent name={fieldName} field={field} value={value} onChange={(val: any) => onChange("value", val)} />
);
}
const selected = Array.isArray(value) ? value : []; const selected = Array.isArray(value) ? value : [];
return ( return (
@@ -211,6 +240,7 @@ export interface FilterBarProps {
onApply: (values: Record<string, any>) => void; onApply: (values: Record<string, any>) => void;
onClear: () => void; onClear: () => void;
components?: FilterBarComponents; components?: FilterBarComponents;
fieldComponents?: FieldComponents;
} }
export default function FilterBar({ export default function FilterBar({
@@ -221,6 +251,7 @@ export default function FilterBar({
onApply, onApply,
onClear, onClear,
components: filterComponents, components: filterComponents,
fieldComponents,
}: FilterBarProps) { }: FilterBarProps) {
const [open, setOpen] = React.useState(false); const [open, setOpen] = React.useState(false);
const [draft, setDraft] = React.useState<Record<string, any>>(() => ({ ...appliedValues })); const [draft, setDraft] = React.useState<Record<string, any>>(() => ({ ...appliedValues }));
@@ -298,7 +329,7 @@ export default function FilterBar({
{field.label} {field.label}
</Box> </Box>
{renderFilterInput(fieldName, field, options, raw, (key, val) => {renderFilterInput(fieldName, field, options, raw, (key, val) =>
updateDraft(fieldName, key, val), filterComponents updateDraft(fieldName, key, val), filterComponents, fieldComponents
)} )}
</Box> </Box>
); );

View File

@@ -184,6 +184,7 @@ export default function ResourceView({ config, onNavigateToResource, fieldCompon
appliedValues={appliedFilters} appliedValues={appliedFilters}
onApply={setAppliedFilters} onApply={setAppliedFilters}
onClear={() => setAppliedFilters({})} onClear={() => setAppliedFilters({})}
fieldComponents={components}
/> />
)} )}
<EnhancedTable <EnhancedTable

View File

@@ -52,6 +52,8 @@ export type FieldComponents = Partial<Record<FieldType, FieldComponent>> & {
relation?: FieldComponent; relation?: FieldComponent;
image?: FieldComponent; image?: FieldComponent;
default?: FieldComponent; default?: FieldComponent;
FormField?: React.ComponentType<any>;
GenericForm?: React.ComponentType<any>;
}; };
export interface CellRendererProps { export interface CellRendererProps {

View File

@@ -4,7 +4,6 @@ import {
Container, Container,
Paper, Paper,
Typography, Typography,
TextField,
Button, Button,
IconButton, IconButton,
CircularProgress, CircularProgress,
@@ -15,8 +14,6 @@ import {
DialogContent, DialogContent,
DialogContentText, DialogContentText,
DialogActions, DialogActions,
Switch,
FormControlLabel,
Chip, Chip,
} from "@mui/material"; } from "@mui/material";
import DeleteIcon from "@mui/icons-material/Delete"; import DeleteIcon from "@mui/icons-material/Delete";
@@ -125,22 +122,17 @@ export default function ReportSnapshots() {
</Typography> </Typography>
<Box sx={{ display: "flex", flexDirection: "column", gap: 2 }}> <Box sx={{ display: "flex", flexDirection: "column", gap: 2 }}>
{ignoreSelfField && components?.FormField ? ( {ignoreSelfField && components?.FormField && (
<components.FormField <components.FormField
name="ignore_self" name="ignore_self"
field={ignoreSelfField} field={ignoreSelfField}
value={ignoreSelf} value={ignoreSelf}
onChange={(val: boolean) => setIgnoreSelf(val)} onChange={(val: boolean) => setIgnoreSelf(val)}
/> />
) : (
<FormControlLabel
control={<Switch checked={ignoreSelf} onChange={(e) => setIgnoreSelf(e.target.checked)} />}
label="Ignore self-transfers"
/>
)} )}
<Box sx={{ display: "flex", gap: 2 }}> <Box sx={{ display: "flex", gap: 2 }}>
{startDateField && components?.datetime ? ( {startDateField && components?.datetime && (
<Box sx={{ flex: 1 }}> <Box sx={{ flex: 1 }}>
<components.datetime <components.datetime
name="start_date" name="start_date"
@@ -149,18 +141,8 @@ export default function ReportSnapshots() {
onChange={(val: string) => setStartDate(val)} onChange={(val: string) => setStartDate(val)}
/> />
</Box> </Box>
) : (
<TextField
label="Start Date"
type="datetime-local"
value={startDate}
onChange={(e) => setStartDate(e.target.value)}
size="small"
InputLabelProps={{ shrink: true }}
sx={{ flex: 1 }}
/>
)} )}
{endDateField && components?.datetime ? ( {endDateField && components?.datetime && (
<Box sx={{ flex: 1 }}> <Box sx={{ flex: 1 }}>
<components.datetime <components.datetime
name="end_date" name="end_date"
@@ -169,21 +151,11 @@ export default function ReportSnapshots() {
onChange={(val: string) => setEndDate(val)} onChange={(val: string) => setEndDate(val)}
/> />
</Box> </Box>
) : (
<TextField
label="End Date"
type="datetime-local"
value={endDate}
onChange={(e) => setEndDate(e.target.value)}
size="small"
InputLabelProps={{ shrink: true }}
sx={{ flex: 1 }}
/>
)} )}
</Box> </Box>
<Box sx={{ display: "flex", gap: 2 }}> <Box sx={{ display: "flex", gap: 2 }}>
{minAmountField && components?.FormField ? ( {minAmountField && components?.FormField && (
<Box sx={{ flex: 1 }}> <Box sx={{ flex: 1 }}>
<components.FormField <components.FormField
name="min_amount" name="min_amount"
@@ -192,17 +164,8 @@ export default function ReportSnapshots() {
onChange={(val: string) => setMinAmount(val)} onChange={(val: string) => setMinAmount(val)}
/> />
</Box> </Box>
) : (
<TextField
label="Min Amount"
type="number"
value={minAmount}
onChange={(e) => setMinAmount(e.target.value)}
size="small"
sx={{ flex: 1 }}
/>
)} )}
{maxAmountField && components?.FormField ? ( {maxAmountField && components?.FormField && (
<Box sx={{ flex: 1 }}> <Box sx={{ flex: 1 }}>
<components.FormField <components.FormField
name="max_amount" name="max_amount"
@@ -211,15 +174,6 @@ export default function ReportSnapshots() {
onChange={(val: string) => setMaxAmount(val)} onChange={(val: string) => setMaxAmount(val)}
/> />
</Box> </Box>
) : (
<TextField
label="Max Amount"
type="number"
value={maxAmount}
onChange={(e) => setMaxAmount(e.target.value)}
size="small"
sx={{ flex: 1 }}
/>
)} )}
</Box> </Box>

View File

@@ -4,7 +4,7 @@ export const configuration: Record<string, ResourceOverride> = {
expenses: { expenses: {
filterOptions: { filterOptions: {
mode: "client", mode: "client",
fields: ["account", "payee", "tags", "occurred_at", "amount"], fields: ["account", "payee.name", "tags", "occurred_at", "amount"],
}, },
fields: { fields: {
payee: { payee: {
@@ -57,12 +57,12 @@ export const configuration: Record<string, ResourceOverride> = {
format: { format: {
path: 'source.format', path: 'source.format',
}, },
account: { // account: {
refers: 'accounts', // refers: 'accounts',
}, // },
tags: { // tags: {
refers: 'tags', // refers: 'tags',
}, // },
}, },
}, },
accounts: { accounts: {