# Dashboard State Lift + Theme System Refactor ## Summary Refactored dashboard state ownership, centralized theme semantics, and simplified component styling across the application. ## Changes ### Dashboard State Refactor * Moved dashboard state management from `Dashboard.view` into `Dashboard.tsx` * Added centralized `DashboardState` initialization in parent container * Introduced memoized dashboard state setter callbacks: * `toggleFlow` * `setFlow` * `togglePeriodType` * `toggleComparison` * `setSelectedPeriodId` * `setSelectedGroupKey` * Added `DashboardStateSetters` memoized object for prop-driven state management * Removed `onFlowChange` callback pattern * Converted dashboard component into stateless view layer * Renamed component export flow: * `Dashboard.tsx` → removed * `Dashboard.view.tsx` → primary implementation ### Dashboard Models Cleanup * Removed legacy palette configuration interfaces: * `ColorDefinition` * `ThemeAwarePalette` * Removed config-level style palette support from `DashboardConfig` * Renamed `DashboardProps` → `DashboardViewProps` * Added reusable `ColorScheme` interface * Simplified component color contract: * `primary` * `surface` * `text` ### Theme Architecture Refactor * Moved `AppTheme.tsx` into `shared-theme` * Added centralized semantic theme system * Introduced `themeConfig.ts` with semantic tokens: * surface * border * text * Added `semantic` extension to MUI theme typing * Added `flows` palette extension: * outflows * inflows * Centralized flow colors inside theme primitives * Added CSS semantic variables: * `--bg-page` * `--bg-card` * `--bg-elevated` * `--border-default` * `--border-subtle` * `--text-primary` * `--text-secondary` * `--text-muted` ### Theme Mode Improvements * Added explicit `ColorMode` type * Expanded `ColorModeContext`: * `mode` * `setMode` * `toggleColorMode` * Added `CssBaseline` * Added configurable `defaultMode` * Simplified dark theme palette handling * Standardized dark surfaces and shadows * Reduced excessive dark-mode glow/shadow intensity ### Dashboard UI Styling Improvements * Replaced hardcoded dashboard palette config with theme palette usage * Updated dashboard background gradients to use alpha-based semantic colors * Replaced `colorScheme.light` usage with `colorScheme.surface` * Standardized border usage with theme divider tokens * Removed manual dark-mode conditional styling where redundant * Simplified card and progress styling logic ### Shared Theme Customization Cleanup Updated customization layers for improved consistency: * `inputs` * `navigation` * `feedback` * `surfaces` Key improvements: * Reduced dark-mode contrast harshness * Unified divider usage * Replaced hardcoded grayscale backgrounds with semantic surfaces * Simplified hover and active state styling * Reduced shadow intensity across components * Improved dark-mode readability and layering ### Home Page Styling Cleanup * Replaced manual RGBA handling with `alpha()` utility * Improved dark-mode glassmorphism consistency * Updated CTA hover shadow to use theme primary color ### Miscellaneous Cleanup * Updated imports to new theme structure * Removed unused legacy color mode components: * `ColorModeIconDropdown.tsx` * `ColorModeSelect.tsx` * Removed dashboard config style palette definitions * Simplified flow-based color derivation logic ## Result * Cleaner separation of stateful vs presentational dashboard logic * Centralized semantic theming system * Consistent dark/light mode behavior * Reduced styling duplication * Improved maintainability and extensibility of theme architecture * Simplified dashboard component contracts * Better UI consistency across surfaces and controls Reviewed-on: #6 Co-authored-by: Vishesh 'ironeagle' Bangotra <aetoskia@gmail.com> Co-committed-by: Vishesh 'ironeagle' Bangotra <aetoskia@gmail.com>
280 lines
8.3 KiB
TypeScript
280 lines
8.3 KiB
TypeScript
import * as React from 'react';
|
|
import { Theme, alpha, Components } from '@mui/material/styles';
|
|
import { SvgIconProps } from '@mui/material/SvgIcon';
|
|
import { buttonBaseClasses } from '@mui/material/ButtonBase';
|
|
import { dividerClasses } from '@mui/material/Divider';
|
|
import { menuItemClasses } from '@mui/material/MenuItem';
|
|
import { selectClasses } from '@mui/material/Select';
|
|
import { tabClasses } from '@mui/material/Tab';
|
|
import UnfoldMoreRoundedIcon from '@mui/icons-material/UnfoldMoreRounded';
|
|
import { gray, brand } from '../themePrimitives';
|
|
|
|
/* eslint-disable import/prefer-default-export */
|
|
export const navigationCustomizations: Components<Theme> = {
|
|
MuiMenuItem: {
|
|
styleOverrides: {
|
|
root: ({ theme }) => ({
|
|
borderRadius: (theme.vars || theme).shape.borderRadius,
|
|
padding: '6px 8px',
|
|
[`&.${menuItemClasses.focusVisible}`]: {
|
|
backgroundColor: 'transparent',
|
|
},
|
|
[`&.${menuItemClasses.selected}`]: {
|
|
[`&.${menuItemClasses.focusVisible}`]: {
|
|
backgroundColor: alpha(theme.palette.action.selected, 0.3),
|
|
},
|
|
},
|
|
}),
|
|
},
|
|
},
|
|
MuiMenu: {
|
|
styleOverrides: {
|
|
list: {
|
|
gap: '0px',
|
|
[`&.${dividerClasses.root}`]: {
|
|
margin: '0 -8px',
|
|
},
|
|
},
|
|
paper: ({ theme }) => ({
|
|
marginTop: '4px',
|
|
borderRadius: (theme.vars || theme).shape.borderRadius,
|
|
border: `1px solid ${(theme.vars || theme).palette.divider}`,
|
|
backgroundImage: 'none',
|
|
background: 'hsl(0, 0%, 100%)',
|
|
boxShadow:
|
|
'hsla(220, 30%, 5%, 0.07) 0px 4px 16px 0px, hsla(220, 25%, 10%, 0.07) 0px 8px 16px -5px',
|
|
[`& .${buttonBaseClasses.root}`]: {
|
|
'&.Mui-selected': {
|
|
backgroundColor: alpha(theme.palette.action.selected, 0.3),
|
|
},
|
|
},
|
|
...theme.applyStyles('dark', {
|
|
background: (theme.vars || theme).palette.background.paper,
|
|
boxShadow: '0 4px 16px rgba(0, 0, 0, 0.4), 0 8px 24px rgba(0, 0, 0, 0.3)',
|
|
}),
|
|
}),
|
|
},
|
|
},
|
|
MuiSelect: {
|
|
defaultProps: {
|
|
IconComponent: React.forwardRef<SVGSVGElement, SvgIconProps>((props, ref) => (
|
|
<UnfoldMoreRoundedIcon fontSize="small" {...props} ref={ref} />
|
|
)),
|
|
},
|
|
styleOverrides: {
|
|
root: ({ theme }) => ({
|
|
borderRadius: (theme.vars || theme).shape.borderRadius,
|
|
border: '1px solid',
|
|
borderColor: gray[200],
|
|
backgroundColor: (theme.vars || theme).palette.background.paper,
|
|
boxShadow: `inset 0 1px 0 1px hsla(220, 0%, 100%, 0.6), inset 0 -1px 0 1px hsla(220, 35%, 90%, 0.5)`,
|
|
'&:hover': {
|
|
borderColor: gray[300],
|
|
backgroundColor: (theme.vars || theme).palette.background.paper,
|
|
boxShadow: 'none',
|
|
},
|
|
[`&.${selectClasses.focused}`]: {
|
|
outlineOffset: 0,
|
|
borderColor: gray[400],
|
|
},
|
|
'&:before, &:after': {
|
|
display: 'none',
|
|
},
|
|
|
|
...theme.applyStyles('dark', {
|
|
borderRadius: (theme.vars || theme).shape.borderRadius,
|
|
borderColor: (theme.vars || theme).palette.divider,
|
|
backgroundColor: (theme.vars || theme).palette.background.paper,
|
|
boxShadow: 'inset 0 1px 0 hsla(0, 0%, 100%, 0.05)',
|
|
'&:hover': {
|
|
borderColor: 'hsla(0, 0%, 100%, 0.15)',
|
|
backgroundColor: (theme.vars || theme).palette.background.paper,
|
|
boxShadow: 'none',
|
|
},
|
|
[`&.${selectClasses.focused}`]: {
|
|
outlineOffset: 0,
|
|
borderColor: 'hsl(210, 55%, 55%)',
|
|
},
|
|
'&:before, &:after': {
|
|
display: 'none',
|
|
},
|
|
}),
|
|
}),
|
|
select: ({ theme }) => ({
|
|
display: 'flex',
|
|
alignItems: 'center',
|
|
...theme.applyStyles('dark', {
|
|
display: 'flex',
|
|
alignItems: 'center',
|
|
'&:focus-visible': {
|
|
backgroundColor: (theme.vars || theme).palette.background.default,
|
|
},
|
|
}),
|
|
}),
|
|
},
|
|
},
|
|
MuiLink: {
|
|
defaultProps: {
|
|
underline: 'none',
|
|
},
|
|
styleOverrides: {
|
|
root: ({ theme }) => ({
|
|
color: (theme.vars || theme).palette.text.primary,
|
|
fontWeight: 500,
|
|
position: 'relative',
|
|
textDecoration: 'none',
|
|
width: 'fit-content',
|
|
'&::before': {
|
|
content: '""',
|
|
position: 'absolute',
|
|
width: '100%',
|
|
height: '1px',
|
|
bottom: 0,
|
|
left: 0,
|
|
backgroundColor: (theme.vars || theme).palette.text.secondary,
|
|
opacity: 0.3,
|
|
transition: 'width 0.3s ease, opacity 0.3s ease',
|
|
},
|
|
'&:hover::before': {
|
|
width: 0,
|
|
},
|
|
'&:focus-visible': {
|
|
outline: `3px solid ${alpha(brand[500], 0.5)}`,
|
|
outlineOffset: '4px',
|
|
borderRadius: '2px',
|
|
},
|
|
}),
|
|
},
|
|
},
|
|
MuiDrawer: {
|
|
styleOverrides: {
|
|
paper: ({ theme }) => ({
|
|
backgroundColor: (theme.vars || theme).palette.background.default,
|
|
borderRight: `1px solid ${(theme.vars || theme).palette.divider}`,
|
|
}),
|
|
},
|
|
},
|
|
MuiPaginationItem: {
|
|
styleOverrides: {
|
|
root: ({ theme }) => ({
|
|
'&.Mui-selected': {
|
|
color: 'white',
|
|
backgroundColor: (theme.vars || theme).palette.grey[900],
|
|
},
|
|
...theme.applyStyles('dark', {
|
|
'&.Mui-selected': {
|
|
color: 'black',
|
|
backgroundColor: (theme.vars || theme).palette.grey[50],
|
|
},
|
|
}),
|
|
}),
|
|
},
|
|
},
|
|
MuiTabs: {
|
|
styleOverrides: {
|
|
root: { minHeight: 'fit-content' },
|
|
indicator: ({ theme }) => ({
|
|
backgroundColor: (theme.vars || theme).palette.grey[800],
|
|
...theme.applyStyles('dark', {
|
|
backgroundColor: (theme.vars || theme).palette.grey[200],
|
|
}),
|
|
}),
|
|
},
|
|
},
|
|
MuiTab: {
|
|
styleOverrides: {
|
|
root: ({ theme }) => ({
|
|
padding: '6px 8px',
|
|
marginBottom: '8px',
|
|
textTransform: 'none',
|
|
minWidth: 'fit-content',
|
|
minHeight: 'fit-content',
|
|
color: (theme.vars || theme).palette.text.secondary,
|
|
borderRadius: (theme.vars || theme).shape.borderRadius,
|
|
border: '1px solid',
|
|
borderColor: 'transparent',
|
|
':hover': {
|
|
color: (theme.vars || theme).palette.text.primary,
|
|
backgroundColor: gray[100],
|
|
borderColor: gray[200],
|
|
},
|
|
[`&.${tabClasses.selected}`]: {
|
|
color: gray[900],
|
|
},
|
|
...theme.applyStyles('dark', {
|
|
':hover': {
|
|
color: (theme.vars || theme).palette.text.primary,
|
|
backgroundColor: alpha((theme.vars || theme).palette.common.white, 0.08),
|
|
borderColor: (theme.vars || theme).palette.divider,
|
|
},
|
|
[`&.${tabClasses.selected}`]: {
|
|
color: '#fff',
|
|
},
|
|
}),
|
|
}),
|
|
},
|
|
},
|
|
MuiStepConnector: {
|
|
styleOverrides: {
|
|
line: ({ theme }) => ({
|
|
borderTop: '1px solid',
|
|
borderColor: (theme.vars || theme).palette.divider,
|
|
flex: 1,
|
|
borderRadius: '99px',
|
|
}),
|
|
},
|
|
},
|
|
MuiStepIcon: {
|
|
styleOverrides: {
|
|
root: ({ theme }) => ({
|
|
color: 'transparent',
|
|
border: `1px solid ${gray[400]}`,
|
|
width: 12,
|
|
height: 12,
|
|
borderRadius: '50%',
|
|
'& text': {
|
|
display: 'none',
|
|
},
|
|
'&.Mui-active': {
|
|
border: 'none',
|
|
color: (theme.vars || theme).palette.primary.main,
|
|
},
|
|
'&.Mui-completed': {
|
|
border: 'none',
|
|
color: (theme.vars || theme).palette.success.main,
|
|
},
|
|
...theme.applyStyles('dark', {
|
|
border: `1px solid ${gray[700]}`,
|
|
'&.Mui-active': {
|
|
border: 'none',
|
|
color: (theme.vars || theme).palette.primary.light,
|
|
},
|
|
'&.Mui-completed': {
|
|
border: 'none',
|
|
color: (theme.vars || theme).palette.success.light,
|
|
},
|
|
}),
|
|
variants: [
|
|
{
|
|
props: { completed: true },
|
|
style: {
|
|
width: 12,
|
|
height: 12,
|
|
},
|
|
},
|
|
],
|
|
}),
|
|
},
|
|
},
|
|
MuiStepLabel: {
|
|
styleOverrides: {
|
|
label: ({ theme }) => ({
|
|
'&.Mui-completed': {
|
|
opacity: 0.6,
|
|
...theme.applyStyles('dark', { opacity: 0.5 }),
|
|
},
|
|
}),
|
|
},
|
|
},
|
|
};
|